refactor(atomic): refactor SmartSnippetFeedbackModal functional components #6600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional components Co-authored-by: alexprudhomme <[email protected]>
Co-authored-by: alexprudhomme <[email protected]>
Copilot stopped work on behalf of
alexprudhomme due to an error
November 20, 2025 14:13
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
...mmon/smart-snippets/atomic-smart-snippet-feedback-modal/smart-snippet-feedback-modal.spec.ts
Fixed
Show fixed
Hide fixed
...ts/common/smart-snippets/atomic-smart-snippet-feedback-modal/smart-snippet-feedback-modal.ts
Outdated
Show resolved
Hide resolved
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
changed the title
alexprudhomme
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
Copilot finished reviewing on behalf of
alexprudhomme
November 20, 2025 18:22
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates six SmartSnippet Feedback Modal functional components from Stencil to Lit. The migration follows the established pattern of creating new Lit versions with a render* naming convention while preserving the original Stencil versions with a stencil- prefix for backward compatibility. Comprehensive unit tests were added for all migrated components.
Key Changes
- Created Lit functional components: All six functional components (Header, Body, Options, Option, Details, Footer) were migrated to Lit with proper TypeScript types and reactive directives
- Preserved Stencil versions: Original components were renamed with
stencil-prefix to maintain compatibility with existing parent components - Added comprehensive tests: Each functional component has thorough unit test coverage following Vitest conventions
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
stencil-smart-snippet-feedback-modal-common.tsx |
Renamed original Stencil file with deprecation notices |
modal-header.ts |
New Lit functional component for modal header |
modal-body.ts |
New Lit functional component for form body wrapper |
modal-options.ts |
New Lit functional component for options fieldset |
modal-option.ts |
New Lit functional component for individual radio option |
modal-details.ts |
New Lit functional component for details textarea (has issues) |
modal-footer.ts |
New Lit functional component for footer with buttons |
feedback-options.ts |
Extracted feedback options data structure |
*.spec.ts (7 files) |
Comprehensive unit tests for all components |
atomic-smart-snippet-feedback-modal.tsx |
Updated import path to renamed Stencil file |
atomic-insight-smart-snippet-feedback-modal.tsx |
Updated import path to renamed Stencil file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ic/src/components/common/smart-snippets/atomic-smart-snippet-feedback-modal/modal-details.ts
Outdated
Show resolved
Hide resolved
...ic/src/components/common/smart-snippets/atomic-smart-snippet-feedback-modal/modal-details.ts
Outdated
Show resolved
Hide resolved
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
Prerelease (CDN)
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.